Skip to content

Fix Readme file - Cloudhsm#8906

Merged
kairu-ms merged 1 commit intoAzure:mainfrom
emmeliaAra:cloudHsm-2025-03-31-updateReadme
Jul 14, 2025
Merged

Fix Readme file - Cloudhsm#8906
kairu-ms merged 1 commit intoAzure:mainfrom
emmeliaAra:cloudHsm-2025-03-31-updateReadme

Conversation

@emmeliaAra
Copy link
Copy Markdown
Member

@emmeliaAra emmeliaAra commented Jun 26, 2025 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 26, 2025 13:20
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jun 26, 2025 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jun 26, 2025

Hi @emmeliaAra,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jun 26, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copilot AI reviewed Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CloudHSM README by removing outdated command examples for showing backup and restore statuses.

  • Removed the backup status command example
  • Removed the restore status command example
Comments suppressed due to low confidence (2)

src/cloudhsm/README.md:83

  • [nitpick] The removal of the 'Show backup status' section is clear; however, consider adding a note in the README to inform users that this command has been deprecated or replaced.
    --blob-container-uri "https://mystorageaccount.blob.core.windows.net/backups"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2025

Hi @emmeliaAra

Release Suggestions

Module: cloudhsm

  • Please log updates into to src/cloudhsm/HISTORY.rst
  • Update VERSION to 1.0.0b2 in src/cloudhsm/setup.py

Notes

@yonzhan yonzhan requested review from jsntcy and kairu-ms June 26, 2025 13:42
@kairu-ms
Copy link
Copy Markdown
Contributor

kairu-ms commented Jul 3, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jul 3, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@emmeliaAra
Copy link
Copy Markdown
Member Author

emmeliaAra commented Jul 3, 2025

@kairu-ms can we merge this PR ?

@kairu-ms kairu-ms merged commit bd5856e into Azure:main Jul 14, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kairu-ms kairu-ms kairu-ms approved these changes

@jsntcy jsntcy Awaiting requested review from jsntcy

+2 more reviewers

@seanmorrissey98 seanmorrissey98 seanmorrissey98 approved these changes

@sushiv4 sushiv4 sushiv4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kairu-ms kairu-ms

Labels

None yet

Projects

None yet

Milestone

August 2025 (2025-08-05)

Development

Successfully merging this pull request may close these issues.

6 participants

@emmeliaAra @yonzhan @kairu-ms @seanmorrissey98 @sushiv4